Browse code

textops: RFC2543 is broken

commit cbcc27ef8b1674448bd8b1c45f03388e36f65f51 broke RFC2543 hold

there's no need to check for sendrecv_mode, is_on_hold is either set or not in sdp_stream and/or sdp_session

(cherry picked from commit 3ee0670ee9ca5e2812fd90cccef3a7ae4e55a3b4)

lazedo authored on 06/09/2021 23:35:52
Showing 1 changed files
... ...
@@ -4367,13 +4367,10 @@ static int ki_is_audio_on_hold(sip_msg_t *msg)
4367 4367
 				if(!sdp_stream) break;
4368 4368
 				if(sdp_stream->media.len==AUDIO_STR_LEN &&
4369 4369
 					strncmp(sdp_stream->media.s,AUDIO_STR,AUDIO_STR_LEN)==0 &&
4370
-					sdp_stream->sendrecv_mode.len &&
4371 4370
 					sdp_stream->is_on_hold)
4372 4371
 					return sdp_stream->is_on_hold;
4373 4372
 				if(sdp_stream->media.len==AUDIO_STR_LEN &&
4374 4373
 					strncmp(sdp_stream->media.s,AUDIO_STR,AUDIO_STR_LEN)==0 &&
4375
-					!sdp_stream->sendrecv_mode.len &&
4376
-					sdp_session->sendrecv_mode.len &&
4377 4374
 					sdp_session->is_on_hold)
4378 4375
 					return sdp_session->is_on_hold;
4379 4376
 				sdp_stream_num++;