Browse code

tm: remove unnecessary TMCB_ACK_NEG_IN callback call

- TMCB_ACK_NEG_IN was called in an if branch where the initial
condition was the message to be an INVITE; this was not affecting
anything for the moment since this callback wasn't used but in case
some piece of code would have used this callback it would be called
not only for hop-by-hop ACKs but also INVITEs

Closes #1871

iionita authored on 12/03/2019 13:50:09
Showing 1 changed files
... ...
@@ -2303,14 +2303,6 @@ int reply_received( struct sip_msg  *p_msg )
2303 2303
 									t, &onsend_params);
2304 2304
 						}
2305 2305
 					}
2306
-					if (unlikely(has_tran_tmcbs(t, TMCB_ACK_NEG_IN))){
2307
-						INIT_TMCB_ONSEND_PARAMS(onsend_params,
2308
-								t->uas.request, p_msg, &uac->request,
2309
-								&uac->request.dst, ack, ack_len,
2310
-								TMCB_LOCAL_F, branch, TYPE_LOCAL_ACK);
2311
-						run_trans_callbacks_off_params(TMCB_ACK_NEG_IN,
2312
-								t, &onsend_params);
2313
-					}
2314 2306
 					shm_free(ack);
2315 2307
 				}
2316 2308
 			} else if (is_local(t) /*&& 200 <= msg_status < 300*/) {