Browse code

- fixed lots of parse_headers bad usage (no check that the header is !=0 after running parser_headers).

Andrei Pelinescu-Onciul authored on 02/07/2004 15:32:55
Showing 3 changed files
... ...
@@ -45,7 +45,7 @@ export makefile_defs
45 45
 VERSION = 0
46 46
 PATCHLEVEL = 8
47 47
 SUBLEVEL =   12
48
-EXTRAVERSION = -1rc2
48
+EXTRAVERSION = -1rc3
49 49
 
50 50
 RELEASE=$(VERSION).$(PATCHLEVEL).$(SUBLEVEL)$(EXTRAVERSION)
51 51
 OS = $(shell uname -s | sed -e s/SunOS/solaris/ | tr "[A-Z]" "[a-z]")
... ...
@@ -2,15 +2,11 @@ $Id$
2 2
 
3 3
 ( - todo, x - done)
4 4
 
5
-- nathelper: extract_body broken-> uses content_length value form the 
6
- message instead of recalculating it + duplicate code for get_body()
7
-- fix check_sel_op -- add proto for uri proto checks
8
-- add setting for infinite tcp conn life?
9
-
10
-- fix 2 different fixups for diff. no of parameter
11
- (add no of params to struct action?) -- linked to var. no. of params
12
-x alias support fot tcp/tls port numbers
13
-- warning builder set_advertised address support
5
+- error <-> warning for bad checksum and sport==0
6
+- drop sport==0 messages
7
+- check all parse_headers occurences (and fix xlog!)
8
+- loose_roote : use parse_orig_uri instead of parse_uri
9
+
14 10
 - grep parse_uri & replace with parse_sip_msg_uri (e.g do_action!)
15 11
 x update AUTHORS, debian/copyright, ser.8, ser.cfg.5 from stable
16 12
 x update Makefile*  from stable
... ...
@@ -18,16 +14,14 @@ x update all package specs from stable
18 14
 - add BUG checks for  fd > 0 && fd <= maxfd to all selects?
19 15
 x tcp_main_loop: BUG cases should "conitnue;"
20 16
 x change len_gt into and expr (e.g msg:len).
21
-x sipit: uri == myself doesn't match tls port = 5061 
22
-  -- updated: new socket_info list code should fix it
23
-x sipit: fix check_self & *_alias to work with tcp & tls
24
-  -- updated: new socket_info list code should fix it
17
+- sipit: uri == myself doesn't match tls port = 5061
18
+- sipit: fix check_self & *_alias to work with tcp & tls
25 19
 x sipit: fix ipv6 references in check_self
26 20
 x regex subst on uris?
27 21
 x port receive.c pre_script_cb fix from stable
28
-x extend alias to include port numbers :
22
+- extend alias to include port numbers :
29 23
     something like alias= foo1.bar:5080 foo2.bar foo3.bar:*
30
-x extend listen and alias to include port numbers and protocol:
24
+- extend listen and alias to include port numbers and protocol:
31 25
        tcp foo.bar:5063, udp foo.bar:5062, foo2.bar
32 26
 x added set_advertised_{address,port} -- was: add force_via, force_srcip a.s.o
33 27
 (the advertised addresses should be overwritable from the script).
... ...
@@ -126,7 +120,7 @@ x man page
126 120
 - autoconf scripts
127 121
 x Debian package build files
128 122
 x the same for rpm
129
-x the same for *BSD
123
+- the same for FreeBSD and Slackware
130 124
 
131 125
 
132 126
 x jku: branch hash computation over canonical values
... ...
@@ -162,6 +162,10 @@ static inline int parse_dlg( struct sip_msg *msg )
162 162
 		LOG(L_ERR, "ERROR: tid_matching: From or Cseq or To invalid\n");
163 163
 		return 0;
164 164
 	}
165
+	if ((msg->from==0)||(msg->cseq==0)||(msg->to==0)) {
166
+		LOG(L_ERR, "ERROR: tid_matching: missing From or Cseq or To\n");
167
+		return 0;
168
+	}
165 169
 	if (parse_from_header(msg)==-1) {
166 170
 		LOG(L_ERR, "ERROR: tid_matching: From broken\n");
167 171
 		return 0;