Browse code

CONTRIBUTING.md: added developer access section

Daniel-Constantin Mierla authored on 18/02/2018 07:24:36
Showing 1 changed files
... ...
@@ -77,9 +77,6 @@ and commit history, there are several *rules* required for each contribution.
77 77
   * code **should** be formatted with **clang-format** or to match the style of
78 78
   the component that the commit applies to. The `.clang-format` file is part of
79 79
   Kamailio source code tree, in the root folder.
80
-  * personal branches of developers done inside Kamailio GIT repository must be
81
-  prefixed with `developerid/`, e.g., `alice/new-feature`. Do not use just
82
-  `new-feature` or `alice-new-feature` or other variant without `developerid/`.
83 80
 
84 81
 
85 82
 ### Commit Message Format ###
... ...
@@ -135,6 +132,25 @@ The above content about commit message format is taken from Kamailio wiki page:
135 132
   * https://www.kamailio.org/wiki/devel/git-commit-guidelines
136 133
   * it is recommended you read that one as well.
137 134
 
135
+### Developer Access ###
136
+
137
+  * developer access (commit rights) to Kamailio GIT repository is granted to
138
+  people that contribute relevant components (e.g., modules) or have consistent
139
+  contributions over a long interval of time
140
+  * each developer has to create an account on github.com portal. The
141
+  `developerid` is the username on github.com portal
142
+  * after getting developer access, it is still recommended to use pull request
143
+  for commits done to other components of Kamailio, to allow the main developer
144
+  of the component as well as the other developers to review the changes
145
+  * commits to own components can be pushed directly, without a pull request.
146
+  However, if the developer wants other people to review the changes, using a
147
+  pull request is the way to do it
148
+  * personal branches of developers done inside Kamailio GIT repository must be
149
+  prefixed with `developerid/`, e.g., `alice/new-feature`. Do not use just
150
+  `new-feature` or `alice-new-feature` or other variant without `developerid/`
151
+  * the [Contributions Basic Rules](#basic-rules) from the sections above have
152
+  to be followed as well after getting developer access
153
+
138 154
 ## Reporting Issues ##
139 155
 
140 156
 Whenever reporting an issue, along with the description of the problems, try to