Browse code

tm: add missing line breaks in log statements

Henning Westerholt authored on 05/06/2019 20:24:09
Showing 7 changed files
... ...
@@ -117,7 +117,7 @@ int register_dlg_tmcb(int types, dlg_t *dlg, transaction_cb f, void *param)
117 117
 		return E_BUG;
118 118
 	}
119 119
 	if(f == 0) {
120
-		LM_CRIT("null callback function");
120
+		LM_CRIT("null callback function\n");
121 121
 		return E_BUG;
122 122
 	}
123 123
 	return insert_tmcb(&dlg->dlg_callbacks, types, f, param, NULL);
... ...
@@ -602,28 +602,28 @@ static int t_uac_check_msg(struct sip_msg* msg,
602 602
 	char ch;
603 603
 
604 604
 	if (body->len && !msg->content_type) {
605
-		LM_ERR("Content-Type missing");
605
+		LM_ERR("Content-Type missing\n");
606 606
 		goto err;
607 607
 	}
608 608
 
609 609
 	if (body->len && msg->content_length) {
610
-		LM_ERR("Content-Length disallowed");
610
+		LM_ERR("Content-Length disallowed\n");
611 611
 		goto err;
612 612
 	}
613 613
 
614 614
 	if (!msg->to) {
615
-		LM_ERR("To missing");
615
+		LM_ERR("To missing\n");
616 616
 		goto err;
617 617
 	}
618 618
 
619 619
 	if (!msg->from) {
620
-		LM_ERR("From missing");
620
+		LM_ERR("From missing\n");
621 621
 		goto err;
622 622
 	}
623 623
 
624 624
 	/* we also need to know if there is from-tag and add it otherwise */
625 625
 	if (parse_from_header(msg) < 0) {
626
-		LM_ERR("Error in From");
626
+		LM_ERR("Error in From\n");
627 627
 		goto err;
628 628
 	}
629 629
 
... ...
@@ -640,14 +640,14 @@ static int t_uac_check_msg(struct sip_msg* msg,
640 640
 			} else {
641 641
 				DBG("check_msg: Found non-numerical in CSeq: <%i>='%c'\n",
642 642
 						(unsigned int)ch, ch);
643
-				LM_ERR("Non-numerical CSeq");
643
+				LM_ERR("Non-numerical CSeq\n");
644 644
 				goto err;
645 645
 			}
646 646
 		}
647 647
 
648 648
 		if (parsed_cseq->method.len != method->len ||
649 649
 				memcmp(parsed_cseq->method.s, method->s, method->len) !=0 ) {
650
-			LM_ERR("CSeq method mismatch");
650
+			LM_ERR("CSeq method mismatch\n");
651 651
 			goto err;
652 652
 		}
653 653
 	} else {
... ...
@@ -684,7 +684,7 @@ int t_uac_send(str *method, str *ruri, str *nexthop, str *send_socket,
684 684
 
685 685
 	/* check and parse parameters */
686 686
 	if (method->len<=0){
687
-		LM_ERR("Empty method");
687
+		LM_ERR("Empty method\n");
688 688
 		return -1;
689 689
 	}
690 690
 	if (parse_uri(ruri->s, ruri->len, &p_uri)<0){
... ...
@@ -724,7 +724,7 @@ int t_uac_send(str *method, str *ruri, str *nexthop, str *send_socket,
724 724
 	faked_msg.len=headers->len;
725 725
 	faked_msg.buf=faked_msg.unparsed=headers->s;
726 726
 	if (parse_headers(&faked_msg, HDR_EOH_F, 0)==-1){
727
-		LM_ERR("Invalid headers");
727
+		LM_ERR("Invalid headers\n");
728 728
 		return -1;
729 729
 	}
730 730
 	/* at this moment all the parameters are parsed => more sanity checks */
... ...
@@ -735,7 +735,7 @@ int t_uac_send(str *method, str *ruri, str *nexthop, str *send_socket,
735 735
 	}
736 736
 	if(get_hfblock(nexthop->len? nexthop: ruri, faked_msg.headers,
737 737
 			PROTO_NONE, ssock, &hfb)<0) {
738
-		LM_ERR("failed to get the block of headers");
738
+		LM_ERR("failed to get the block of headers\n");
739 739
 		goto error;
740 740
 	}
741 741
 	/* proceed to transaction creation */
... ...
@@ -773,7 +773,7 @@ int t_uac_send(str *method, str *ruri, str *nexthop, str *send_socket,
773 773
 	ret = t_uac(&uac_req);
774 774
 
775 775
 	if (ret <= 0) {
776
-		LM_ERR("UAC error");
776
+		LM_ERR("UAC error\n");
777 777
 		goto error01;
778 778
 	}
779 779
 error01:
... ...
@@ -1220,7 +1220,7 @@ static struct cancel_reason* cancel_reason_pack(short cause, void* data,
1220 1220
 			if (unlikely(code_len==0)) {
1221 1221
 				shm_free(cr);
1222 1222
 				cr = 0;
1223
-				LM_CRIT("not enough space to write reason code");
1223
+				LM_CRIT("not enough space to write reason code\n");
1224 1224
 				goto error;
1225 1225
 			}
1226 1226
 			d+=code_len;
... ...
@@ -680,7 +680,7 @@ static inline int get_uac_rs(sip_msg_t *msg, int is_req, struct rte **rtset)
680 680
 				 * rte list is evaluated => must do a copy of it */
681 681
 				if (duplicate_rr(&new_p, p) < 0) {
682 682
 					pkg_free(t);
683
-					LM_ERR("failed to duplicate RR");
683
+					LM_ERR("failed to duplicate RR\n");
684 684
 					goto err;
685 685
 				}
686 686
 				t->ptr = new_p;
... ...
@@ -407,7 +407,7 @@ int t_continue_helper(unsigned int hash_index, unsigned int label,
407 407
 			exec_post_script_cb(t->uac[branch].reply, cb_type);
408 408
 		}
409 409
 
410
-		LM_DBG("restoring previous environment");
410
+		LM_DBG("restoring previous environment\n");
411 411
 		faked_env( t, 0, 1);
412 412
 
413 413
 		/*lock transaction replies - will be unlocked when reply is relayed*/
... ...
@@ -1828,7 +1828,7 @@ static int w_t_replicate_uri(struct sip_msg  *msg ,
1828 1828
 
1829 1829
 	if(fixup_get_svalue(msg, (gparam_p)uri, &suri)!=0)
1830 1830
 	{
1831
-		LM_ERR("invalid replicate uri parameter");
1831
+		LM_ERR("invalid replicate uri parameter\n");
1832 1832
 		return -1;
1833 1833
 	}
1834 1834
 	return t_replicate_uri(msg, &suri);
... ...
@@ -2651,27 +2651,27 @@ static int w_t_uac_send(sip_msg_t* msg, char* pmethod, char* pruri,
2651 2651
 	str body = STR_NULL;
2652 2652
 
2653 2653
 	if(fixup_get_svalue(msg, (gparam_t*)pmethod, &method)!=0) {
2654
-		LM_ERR("invalid method parameter");
2654
+		LM_ERR("invalid method parameter\n");
2655 2655
 		return -1;
2656 2656
 	}
2657 2657
 	if(fixup_get_svalue(msg, (gparam_t*)pruri, &ruri)!=0) {
2658
-		LM_ERR("invalid ruri parameter");
2658
+		LM_ERR("invalid ruri parameter\n");
2659 2659
 		return -1;
2660 2660
 	}
2661 2661
 	if(fixup_get_svalue(msg, (gparam_t*)pnexthop, &nexthop)!=0) {
2662
-		LM_ERR("invalid nexthop parameter");
2662
+		LM_ERR("invalid nexthop parameter\n");
2663 2663
 		return -1;
2664 2664
 	}
2665 2665
 	if(fixup_get_svalue(msg, (gparam_t*)psock, &send_socket)!=0) {
2666
-		LM_ERR("invalid send socket parameter");
2666
+		LM_ERR("invalid send socket parameter\n");
2667 2667
 		return -1;
2668 2668
 	}
2669 2669
 	if(fixup_get_svalue(msg, (gparam_t*)phdrs, &headers)!=0) {
2670
-		LM_ERR("invalid headers parameter");
2670
+		LM_ERR("invalid headers parameter\n");
2671 2671
 		return -1;
2672 2672
 	}
2673 2673
 	if(fixup_get_svalue(msg, (gparam_t*)pbody, &body)!=0) {
2674
-		LM_ERR("invalid body parameter");
2674
+		LM_ERR("invalid body parameter\n");
2675 2675
 		return -1;
2676 2676
 	}
2677 2677
 
... ...
@@ -240,7 +240,7 @@ static inline int t_run_local_req(
240 240
 		return -1;
241 241
 	}
242 242
 	if (unlikely(set_dst_uri(&lreq, uac_r->dialog->hooks.next_hop))) {
243
-		LM_ERR("failed to set dst_uri");
243
+		LM_ERR("failed to set dst_uri\n");
244 244
 		free_sip_msg(&lreq);
245 245
 		return -1;
246 246
 	}
... ...
@@ -835,7 +835,7 @@ int ack_local_uac(struct cell *trans, str *hdrs, str *body)
835 835
 
836 836
 	if (! (local_ack = local_ack_rb(trans->uac[0].reply, trans, /*branch*/0,
837 837
 			hdrs, body))) {
838
-		LM_ERR("failed to build ACK retransmission buffer");
838
+		LM_ERR("failed to build ACK retransmission buffer\n");
839 839
 		RET_INVALID;
840 840
 	} else {
841 841
 		/* set the new buffer, but only if not already set (conc. invok.) */